RFR: 7903727: Remove the reliance on String Templates feature [v9]

Nizar Benalla nbenalla at openjdk.org
Wed Jun 5 15:09:27 UTC 2024


On Wed, 5 Jun 2024 15:06:45 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

>> This PR aims to replace the usage of string templates with `String::format`, since there will be no string template feature in JDK 23.
>> I tried to keep similar indentation and convert them in-place, to make reviewing the changes easier.
>
> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
> 
>   -create a new `format` method
>   -fix some indetation/spaces

src/main/java/org/openjdk/jextract/impl/ClassSourceBuilder.java line 129:

> 127:     }
> 128: 
> 129:     String format(String s, String... args) {

I added this method here, then I use it in both `appendLines` and `appendIndentedLines`

-------------

PR Review Comment: https://git.openjdk.org/jextract/pull/244#discussion_r1627964301


More information about the jextract-dev mailing list