RFR: 7903758: jextract should avoid temporary file creation [v3]
Jorn Vernee
jvernee at openjdk.org
Tue Jun 25 12:35:24 UTC 2024
On Tue, 25 Jun 2024 12:27:48 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:
>> Athijegannathan Sundararajan has updated the pull request incrementally with one additional commit since the last revision:
>>
>> whitespace issue in codegenerator. Regenerated clang binding
>
> src/main/java/org/openjdk/jextract/clang/Index.java line 130:
>
>> 128: return rv;
>> 129: }
>> 130: }
>
> Can't we use `clang_parseTranslationUnit2`? It also supports unsaved files, but also supports returning error codes. I suppose `clang_createTranslationUnitFromSourceFile` returns `NULL` if parsing fails.
I suggest trying to extend the existing `parseTU` to also accept a list of `Index.UnsavedFile`
-------------
PR Review Comment: https://git.openjdk.org/jextract/pull/251#discussion_r1652730586
More information about the jextract-dev
mailing list