RFR: Fix javadoc generation and add check to testing suite [v2]

[James Yuzawa]

On Thu, 28 Mar 2024 02:59:52 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> James Yuzawa has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix javadoc generation and add check to testing suite
>>   
>>   Motivation: There is bad javadoc being generated. This fixes that and also adds a check to the testing suite to make sure it does not happen again.
>
> test/lib/testlib/TestUtils.java line 89:
> 
>> 87:             System.err.println("javadoc sources @ " + sourcePath.toAbsolutePath());
>> 88:             List<String> commands = new ArrayList<>();
>> 89:             commands.addAll(files);
> 
> I suggest disabling `missing` doclint warnings here, since we have a lot of those, and they drown out the actual errors when javadoc fails.
> Suggestion:
> 
>             commands.add("-Xdoclint:all,-missing");
>             commands.addAll(files);

@JornVernee thank for the review. I have updated the arguments as you suggested and set the base for this PR to master.

-------------

PR Review Comment: https://git.openjdk.org/jextract/pull/227#discussion_r1542810737