RFR: Add support for bin folder in makefile [v2]

Maurizio Cimadamore mcimadamore at openjdk.org
Mon May 27 14:33:27 UTC 2024


On Mon, 27 May 2024 14:30:34 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> A previous PR changed the gradle build to emit launcher scripts in a separate "bin" folder. However, that PR did not make any changes to the makefiles used to produce the binary bundles. This PR rectifies that.
>> 
>> Tested locally.
>
> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Set correct permissions for linux script, to mimic what gradle does

make/Build.gmk line 90:

> 88: 	$(CP) src/main/jextract "$(JEXTRACT_IMAGE_DIR)/bin"
> 89: 	$(CP) src/main/jextract.bat "$(JEXTRACT_IMAGE_DIR)/bin"
> 90: 	$(CHMOD) +x "$(JEXTRACT_IMAGE_DIR)/bin/jextract"

This line is partly unrelated, but it does update the file permissions of the Linux shell, similarly to what happens on Gradle.

-------------

PR Review Comment: https://git.openjdk.org/jextract/pull/247#discussion_r1616130222


More information about the jextract-dev mailing list