RFR: Fix issue with missing JSON classes in make build [v2]

Maurizio Cimadamore mcimadamore at openjdk.org
Fri Sep 6 21:30:25 UTC 2024


On Fri, 6 Sep 2024 20:47:52 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> Currently, the `make` build is broken, since we added a new package, but the make build doesn't build the source files in that package. 
>> 
>> This patch adds compilation of the new sources, and adds the missing `--add-exports` flags when running tests. Instead of listing each package in the javac command, I've switched to module source path-based compilation. So, if we ever change the packages in the future, we should run into the same problem again.
>
> Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:
> 
>   use module-based compilation

I see what you did - e.g. by using  module option we might avoid similar issues in the future. However, we do end up with extra paths (the module name) that we need to take into account - so I'm not sure. I trust your judgment on this one.

-------------

Marked as reviewed by mcimadamore (Reviewer).

PR Review: https://git.openjdk.org/jextract/pull/259#pullrequestreview-2287183220


More information about the jextract-dev mailing list