Integrated: 7903983: Remove redundant findOrThrow method

Nizar Benalla nbenalla at openjdk.org
Thu Apr 3 15:03:14 UTC 2025


On Fri, 28 Mar 2025 14:11:26 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

> `SymbolLookup::FindOrThrow` was introduced in JDK 23, making this method in the generated code redundant:
> 
>   static MemorySegment findOrThrow(String symbol) {
>       return SYMBOL_LOOKUP.findOrThrow(symbol);
>   }
> 
> The generated method should have been dropped in https://github.com/openjdk/jextract/commit/a53f5c05e3ee2cca057cadb78b2e381c39f943d7 but I didn't cleanup all uses of it.
> 
> A small additional cleanup in PR is that the newly added option for framworks now uses `--` rather than `-`
> 
> Edit: all tests pass in CI on all platforms, GitHub failure is unrelated 
> 
> TIA

This pull request has now been integrated.

Changeset: 3fe6e4ea
Author:    Nizar Benalla <nbenalla at openjdk.org>
Committer: Maurizio Cimadamore <mcimadamore at openjdk.org>
URL:       https://git.openjdk.org/jextract/commit/3fe6e4ea9480aa0489407ddd215cdf2a4c9f2430
Stats:     27 lines in 5 files changed: 3 ins; 4 del; 20 mod

7903983: Remove redundant findOrThrow method

Reviewed-by: mcimadamore

-------------

PR: https://git.openjdk.org/jextract/pull/280


More information about the jextract-dev mailing list