RFR: 7903933: Move sharable items from different generations to a common file [v5]
Nizar Benalla
nbenalla at openjdk.org
Wed Apr 16 19:37:52 UTC 2025
On Wed, 16 Apr 2025 19:34:37 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:
>> Please review this patch to move the `C_*` layouts and the static utility methods into separate classes: `LayoutUtils.java` and `FFMUtils.java`, respectively.
>>
>> - The names could later be personalized through a JSON configuration.
>> - We can use static imports if the `-t` option is no used and the files are generated into the default package, in that case we use the classname to call the static methods or use the `C_*` constants.
>>
>> Some tests had to be modified slightly, either by adding new static imports or replacing classnames.
>
> Nizar Benalla has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains eight commits:
>
> - - Move shared symbols to a different class
> - Add option to override the name of the shared symbol class
> - Merge branch 'master' into shareable-items
> - Merge branch 'master' into shareable-items
> - add new option to create a sharable utility class
>
> cleanup: longer cmd option `framework` should use -- rather than -
>
> small other cleanups
> - Merge branch 'master' into shareable-items
> - Revert all changes - starting over from scratch
> - replace hardcoded strings I missed
> - move sharable items to a common class
I've moved the shared symbols to a different class `foo_h$shared` that all headers extend from.
The new command line option was renamed to `--shared-symbols`to allow users to specify the name of the class if they want to.
-------------
PR Comment: https://git.openjdk.org/jextract/pull/278#issuecomment-2810569983
More information about the jextract-dev
mailing list