RFR: Add support for AIX in build process [v7]
Suchismith Roy
sroy at openjdk.org
Wed Dec 10 12:38:05 UTC 2025
On Tue, 9 Dec 2025 18:32:02 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:
>> Suchismith Roy has updated the pull request incrementally with four additional commits since the last revision:
>>
>> - extra lines
>> - extra lines
>> - extra lines
>> - extra lines
>
> src/main/java/org/openjdk/jextract/clang/libclang/Index_h.java line 98:
>
>> 96: } catch (Exception e) {
>> 97: throw new IllegalStateException("Failed to read libclang.version", e);
>> 98: }
>
> FWIW, `clangVersion` is definitely assigned after the try block, so a default value is not needed. Also, `Files::readString` makes this a little simpler:
> Suggestion:
>
> String clangVersion;
> try {
> clangVersion = Files.readString(Path.of(javaHome + "/conf/jextract/libclang.version"));
> } catch (Exception e) {
> throw new IllegalStateException("Failed to read libclang.version", e);
> }
thanks @JornVernee incorporated it.
-------------
PR Review Comment: https://git.openjdk.org/jextract/pull/297#discussion_r2606497361
More information about the jextract-dev
mailing list