RFR: 7904120: Update jcheck configuration to allow more tags
Maurizio Cimadamore
mcimadamore at openjdk.org
Thu Dec 11 09:57:36 UTC 2025
On Thu, 11 Dec 2025 09:52:34 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:
>> Please review this PR to allow the use of release tags such as `jextract-25+4`
>
> .jcheck/conf line 10:
>
>> 8:
>> 9: [repository]
>> 10: tags=jextract(-[123][0-9]\+[0-9]+)
>
> Are you baking in an assumption that build numbers can't be > 39 ? Any reason this shouldn't just be:
>
> `jextract(-[0-9]++[0-9]+)`
>
> (what you wrote is fine, and seems to cover the builds we emitted so far, I'm more trying to understand the rationale)
Comment sent too fast -- you are assuming the first number is a JDK version -- so it will have, presumably, 2 digits, and the first digit is likely 2-3 (but you added 1 probably to be backwards compatible as well -- as we also have jextract builds for JDK 19).
All good,
-------------
PR Review Comment: https://git.openjdk.org/jextract/pull/298#discussion_r2609931157
More information about the jextract-dev
mailing list