RFR: 7903731: Jextract should support macOS frameworks [v2]

Nizar Benalla nbenalla at openjdk.org
Thu Jan 2 19:14:26 UTC 2025


On Tue, 31 Dec 2024 13:30:02 GMT, Marcono1234 <duke at openjdk.org> wrote:

>> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix typos, rename some methods and bump copyright year to 2025
>
> src/main/resources/org/openjdk/jextract/impl/resources/Messages.properties line 94:
> 
>> 92: --mac-framework-dir <dir>          specify the framework directory                              \n\
>> 93: -f <framework>                    specify framework library. -f libGL is equivalent to         \n\
>> 94: \                                      -l :/System/Library/Frameworks/libGL.framework/libGL         \n
> 
> Wrong / inconsistent indentation?
> Suggestion:
> 
> -f <framework>                     specify framework library. -f libGL is equivalent to         \n\
> \                                   -l :/System/Library/Frameworks/libGL.framework/libGL       \n

Thanks. Fixed the first line in [9ce83f3](https://github.com/openjdk/jextract/pull/268/commits/9ce83f363e50b6e7f3fe5dae1612b929b38a7bd3), the spacing in the second line is intentional.

-------------

PR Review Comment: https://git.openjdk.org/jextract/pull/268#discussion_r1901182955


More information about the jextract-dev mailing list