RFR: 7903731: Jextract should support macOS frameworks [v3]

Nizar Benalla nbenalla at openjdk.org
Mon Jan 6 12:47:00 UTC 2025


On Mon, 6 Jan 2025 11:24:09 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   use consistent spacing
>
> src/main/java/org/openjdk/jextract/JextractTool.java line 561:
> 
>> 559:                     Library library = Library.parse(lib);
>> 560:                     Path libPath = Paths.get(library.libSpec());
>> 561:                     if (!useSystemLoadLibrary ||
> 
> Do we accept absolute path for macos frameworks? I thought `-f` only works for _names_ ?

I did this to try to reuse some code.
`-f` is only intended to work with names, otherwise an error should be reported but I will double check.

-------------

PR Review Comment: https://git.openjdk.org/jextract/pull/268#discussion_r1904108080


More information about the jextract-dev mailing list