RFR: Update gradle to version 8.11.1 and fix GitHub actions [v5]
Marcono1234
duke at openjdk.org
Thu Jan 9 23:38:51 UTC 2025
On Mon, 6 Jan 2025 13:00:21 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:
>> Currently the github actions are failing because we depend on versions of the JDK (17 and 22), that are no longer available through the oracle/setup-java github action.
>>
>> There are 2 barriers to upgrading these JDK version to ones that are supported:
>> 1. The current version of Gradle we are using doesn't run on newer Java versions
>> 2. Due to our use of `--enable-preview` and `--release 22` to compile, we are locked to JDK 22.
>>
>> This PR updates Gradle to the latest version, which supports running on Java 23. It also drops the `--enable-preview` flag from compilation, which is not actually needed, allowing us to compile using JDK 23 as well. Both these changes then allow us to use JDK 23 to run Gradle, and as a toolchain JDK, in the GitHub actions. Since JDK 23 is available through oracle/setup-java, GitHub actions will work again.
>
> Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:
>
> Remove validate job name to match others
.github/workflows/test.yml line 24:
> 22: with:
> 23: fetch-depth: 1
> 24: - uses: gradle/wrapper-validation-action at v3
`gradle/wrapper-validation-action` is deprecated, and this causes a warning now, see for example https://github.com/JornVernee/jextract/actions/runs/12632919612/job/35197503582#annotation:3:26
> Warning: This job uses deprecated functionality from the 'gradle/wrapper-validation-action' action. Consult the logs for more details.
> DEPRECATION: The action `gradle/wrapper-validation-action` has been replaced by `gradle/actions/wrapper-validation`. See https://github.com/gradle/actions/blob/main/docs/deprecation-upgrade-guide.md#the-action-gradlewrapper-validation-action-has-been-replaced-by-gradleactionswrapper-validation
-------------
PR Review Comment: https://git.openjdk.org/jextract/pull/264#discussion_r1909586429
More information about the jextract-dev
mailing list