RFR: 7903928: update build.gradle to use JDK 23 [v3]
Athijegannathan Sundararajan
sundar at openjdk.org
Wed Jan 15 09:51:05 UTC 2025
On Wed, 15 Jan 2025 09:24:55 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:
>> build.gradle line 32:
>>
>>> 30:
>>> 31: def llvm_home = project.property("llvm_home")
>>> 32: def jdk_home = project.property("jdk23_home")
>>
>> We should rename this property simply to `jdk_home`.
>
> I agree. Especially now that we only have one "master" (tip) version.
Gradle's jdk is set via JAVA_HOME. It is usual have gradle support for the latest JDK to come bit "late". If we call JDK needed for jextract to be "jdk_Home" and the one needed for gradle as "JAVA_HOME", we may be in a situation where jdk_home points latest JDK (say JDK 25) and JAVA_HOME points whatever then latest Gradle supports. Can we keep jextract use specific JDK version for its build/test as a separately distinctly named variable?
-------------
PR Review Comment: https://git.openjdk.org/jextract/pull/271#discussion_r1916256236
More information about the jextract-dev
mailing list