RFR: 7903925: Only the main generated header class should be public

Maurizio Cimadamore mcimadamore at openjdk.org
Fri Jan 17 11:45:51 UTC 2025


On Thu, 16 Jan 2025 12:22:12 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

> Please review this patch to make the different header classes jextract generates (e.g. foo_h, foo_h_1, foo_h_2, ...) into package-private classes, leaving the main header class (without prefixes) as the only public class.
> 
> While reading the sources, I noticed what seems like small bug in `SourceFileBuilder` introduced in https://github.com/openjdk/jextract/commit/a699148238fad919390d67eeb73805e780a518e8 so I fixed it as part of this patch.
> 
> TIA.

Looks good, thanks!

-------------

Marked as reviewed by mcimadamore (Reviewer).

PR Review: https://git.openjdk.org/jextract/pull/273#pullrequestreview-2558812501


More information about the jextract-dev mailing list