Integrated: 7903925: Only the main generated header class should be public

Nizar Benalla nbenalla at openjdk.org
Mon Jan 20 11:23:51 UTC 2025


On Thu, 16 Jan 2025 12:22:12 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

> Please review this patch to make the different header classes jextract generates (e.g. foo_h, foo_h_1, foo_h_2, ...) into package-private classes, leaving the main header class (without prefixes) as the only public class.
> 
> While reading the sources, I noticed what seems like small bug in `SourceFileBuilder` introduced in https://github.com/openjdk/jextract/commit/a699148238fad919390d67eeb73805e780a518e8 so I fixed it as part of this patch.
> 
> TIA.

This pull request has now been integrated.

Changeset: 0879fa9f
Author:    Nizar Benalla <nbenalla at openjdk.org>
Committer: Maurizio Cimadamore <mcimadamore at openjdk.org>
URL:       https://git.openjdk.org/jextract/commit/0879fa9faaf1ceb328f64fc32e44e88f24d7c5f8
Stats:     22 lines in 2 files changed: 8 ins; 0 del; 14 mod

7903925: Only the main generated header class should be public

Reviewed-by: mcimadamore

-------------

PR: https://git.openjdk.org/jextract/pull/273


More information about the jextract-dev mailing list