RFR: 7903928: update build.gradle to use JDK 23 [v2]
Chen Liang
liach at openjdk.org
Wed Jan 22 03:41:48 UTC 2025
On Tue, 21 Jan 2025 19:16:31 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:
>> We've updated native makefile to use JDK 23 (https://github.com/openjdk/jextract/commit/0b89a462146940a2ec90e34eeb5df3d46d8980d2), build.gradle works & expects jdk 23, it still refers to JDK var as "jdk22_home" and passes --release to be 22. Also jextract version is "22".
>>
>> The mismatch has caused [some confusion](https://mail.openjdk.org/pipermail/panama-dev/2025-January/020915.html).
>>
>> This patch to rename references to `jdk22_home` to `jdk_home`, the jextract version has now been bumped to `23`.
>>
>> This PR has been obtained through a `git merge --squash` of #271.
>>
>> TIA
>
> Nizar Benalla has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>
> - refer to JDK 23
> - Merge remote-tracking branch 'upstream/master' into pull/271
> - Updates based on review comment in pr/271
> - jextract PR #271
README.md line 17:
> 15: ### Building
> 16:
> 17: `jextract` depends on the [C libclang API](https://clang.llvm.org/doxygen/group__CINDEX.html). To build the jextract sources, the easiest option is to download LLVM binaries for your platform, which can be found [here](https://releases.llvm.org/download.html) (version 13.0.0 is recommended). Both the `jextract` tool and the bindings it generates depend heavily on the [Foreign Function & Memory API](https://openjdk.java.net/jeps/454), a suitable [jdk 23 or higher distribution](https://jdk.java.net/23/) is also required.
Suggestion:
`jextract` depends on the [C libclang API](https://clang.llvm.org/doxygen/group__CINDEX.html). To build the jextract sources, the easiest option is to download LLVM binaries for your platform, which can be found [here](https://releases.llvm.org/download.html) (version 13.0.0 is recommended). Both the `jextract` tool and the bindings it generates depend heavily on the [Foreign Function & Memory API](https://openjdk.java.net/jeps/454). A suitable [JDK 23 or higher distribution](https://jdk.java.net/23/) is also required.
nitpick
-------------
PR Review Comment: https://git.openjdk.org/jextract/pull/275#discussion_r1924648651
More information about the jextract-dev
mailing list