RFR: 7903731: Jextract should support macOS frameworks [v12]
Nizar Benalla
nbenalla at openjdk.org
Mon Mar 10 11:34:07 UTC 2025
On Mon, 10 Mar 2025 10:43:09 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:
>> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
>>
>> review feedback: improve error message
>
> src/main/java/org/openjdk/jextract/JextractTool.java line 456:
>
>> 454: paths.forEach(p -> builder.addClangArg("-F" + p));
>> 455: frameworkPaths.addAll(0, paths);
>> 456: }
>
> My only concern left is what now happens on non-mac platforms when `-F` or `-framework` is used. I suppose clang might error out on the flag in the case of `-F`, not sure what happens for `-framework`.
>
> I think these options should perhaps be disabled on platforms besides mac, since they are only intended to be used there.
@mcimadamore What do you think about emitting errors on non-mac platforms?
-------------
PR Review Comment: https://git.openjdk.org/jextract/pull/268#discussion_r1987106905
More information about the jextract-dev
mailing list