RFR: 7903983: Remove redundant findOrThrow method
Maurizio Cimadamore
mcimadamore at openjdk.org
Fri Mar 28 17:52:50 UTC 2025
On Fri, 28 Mar 2025 14:11:26 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:
> `SymbolLookup::FindOrThrow` was introduced in JDK 23, making this method in the generated code redundant:
>
> static MemorySegment findOrThrow(String symbol) {
> return SYMBOL_LOOKUP.findOrThrow(symbol);
> }
>
> The generated method should have been dropped in https://github.com/openjdk/jextract/commit/a53f5c05e3ee2cca057cadb78b2e381c39f943d7 but I didn't cleanup all uses of it.
>
> A small additional cleanup in PR is that the newly added option for framworks now uses `--` rather than `-`
>
> Edit: all tests pass in CI on all platforms, GitHub failure is unrelated
>
> TIA
Looks good!
-------------
Marked as reviewed by mcimadamore (Reviewer).
PR Review: https://git.openjdk.org/jextract/pull/280#pullrequestreview-2726282132
More information about the jextract-dev
mailing list