RFR: 7903933: Move sharable items from different generations to a common file [v7]

Maurizio Cimadamore mcimadamore at openjdk.org
Fri May 2 14:53:01 UTC 2025


On Fri, 2 May 2025 14:30:36 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

>> Please review this patch to move the `C_*` layouts and the static utility methods into separate classes: `LayoutUtils.java` and `FFMUtils.java`, respectively.
>> 
>> - The names could later be personalized through a JSON configuration.
>> - We can use static imports if the `-t` option is no used and the files are generated into the default package, in that case we use the classname to call the static methods or use the `C_*` constants.
>> 
>> Some tests had to be modified slightly, either by adding new static imports or replacing classnames.
>
> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
> 
>   feedback: rename option and consolidate code

Very nice cleanup! Looks good

-------------

Marked as reviewed by mcimadamore (Reviewer).

PR Review: https://git.openjdk.org/jextract/pull/278#pullrequestreview-2812213858


More information about the jextract-dev mailing list