RFR: 7903933: Move sharable items from different generations to a common file [v8]
Nizar Benalla
nbenalla at openjdk.org
Wed May 7 09:20:30 UTC 2025
On Tue, 6 May 2025 17:53:33 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:
>> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
>>
>> update test
>
> src/main/java/org/openjdk/jextract/impl/FunctionalInterfaceBuilder.java line 45:
>
>> 43: private FunctionalInterfaceBuilder(SourceFileBuilder builder, String className, ClassSourceBuilder enclosing,
>> 44: String runtimeHelperName, Type.Function funcType, boolean isNested) {
>> 45: super(builder, isNested ? "public final static" : "public final", Kind.CLASS, className, null, enclosing, runtimeHelperName);
>
> Changes in this file seem unrelated? Leftover from other work?
This change was to make the utility classes final, it's somewhat unrelated to this patch but it didn't seem to be worth a separate PR.
-------------
PR Review Comment: https://git.openjdk.org/jextract/pull/278#discussion_r2077199255
More information about the jextract-dev
mailing list