RFR: 7903933: Move sharable items from different generations to a common file [v8]

[Nizar Benalla]

On Tue, 6 May 2025 17:44:35 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   update test
>
> src/main/java/org/openjdk/jextract/impl/ToplevelBuilder.java line 46:
> 
>> 44:     public static final String PREV_SUFFIX = "#{PREV_SUFFIX}";
>> 45:     private static final String SUFFIX = "#{SUFFIX}";
>> 46:     private static String SHARED;
> 
> I think this was supposed to be `final`?
> Suggestion:
> 
>     private final String shared;

Fixed in [167423e](https://github.com/openjdk/jextract/pull/278/commits/167423e1c23f3b3d2bf092c4cfdf6f465c6c54e1). I had to refractor a couple of methods. `generateInternal` now takes `Options options`, that way I don't need to change the signature every time we add a new command-line option.

-------------

PR Review Comment: https://git.openjdk.org/jextract/pull/278#discussion_r2079616575