RFR: 7903933: Move sharable items from different generations to a common file [v9]

Jorn Vernee jvernee at openjdk.org
Thu May 8 13:01:09 UTC 2025


On Thu, 8 May 2025 12:28:20 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

>> Please review this patch to move the `C_*` layouts and the static utility methods into separate classes: `LayoutUtils.java` and `FFMUtils.java`, respectively.
>> 
>> - The names could later be personalized through a JSON configuration.
>> - We can use static imports if the `-t` option is no used and the files are generated into the default package, in that case we use the classname to call the static methods or use the `C_*` constants.
>> 
>> Some tests had to be modified slightly, either by adding new static imports or replacing classnames.
>
> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
> 
>   feedback from jorn

Marked as reviewed by jvernee (Reviewer).

src/main/java/org/openjdk/jextract/impl/IncludeHelper.java line 90:

> 88: 
> 89:     public String getSharedClassName() {
> 90:         return sharedClassName;

These can now be removed I think?

-------------

PR Review: https://git.openjdk.org/jextract/pull/278#pullrequestreview-2825044208
PR Review Comment: https://git.openjdk.org/jextract/pull/278#discussion_r2079666302


More information about the jextract-dev mailing list