<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof">
Thanks for your report on progress. We'll try to files (I'm not on Windows so it'll take sometime before bug filing). </div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof">
Thanks</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof">
-Sundar</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> jextract-dev <jextract-dev-retn@openjdk.org> on behalf of Manuel Bleichenbacher <manuel.bleichenbacher@gmail.com><br>
<b>Sent:</b> 24 August 2022 02:01<br>
<b>To:</b> jextract-dev@openjdk.org <jextract-dev@openjdk.org><br>
<b>Subject:</b> Re: jextract for operating system API</font>
<div> </div>
</div>
<div>
<div dir="ltr">On Windows, I've made major progress, solved most of the issues and run into a few new ones.
<div><br>
</div>
<div>The main thing is: It's not possible to directly process a header file like winusb.h. Instead, a helper header file needs to be created:</div>
<div><br>
</div>
<div>#include <windows.h></div>
<div>#include <winusb.h></div>
<div><br>
</div>
<div>A mistake I made yesterday was the omission of "-l Kernel32" (or whatever library is needed).</div>
<br class="x_gmail-Apple-interchange-newline">
<div>With these two changes and the use of --include-xxx, more or less all functions, structs and macros can be created. (I didn't yet have time to look into GUID constants like GUID_DEVINTERFACE_USB_DEVICE; they probably don't work due to macro trickery.)</div>
<div><br>
</div>
<div>There are 2 structs that do not work (with rather advanced issues):</div>
<div><br>
</div>
<div>(1) The generated class _USB_NODE_CONNECTION_INFORMATION_EX cannot be instanciated. The constructor throws the exception: java.lang.UnsupportedOperationException: Invalid alignment requirements for layout s16(DeviceAddress)</div>
<div><br>
</div>
<div>This struct (like many USB descriptors) is packed with 16-bit integer values on odd offsets. jextract insists on creating a layout with strict alignment rules. So the generated layout net.codecrete.usb.windows.gen.usbioctl._USB_NODE_CONNECTION_INFORMATION_EX#$struct$LAYOUT
fails, while the manually created layout net.codecrete.usb.windows.USBIOCtl#USB_NODE_CONNECTION_INFORMATION_EX$Struct works.</div>
<div><br>
</div>
<div>(2) The struct _SP_DEVICE_INTERFACE_DETAIL_DATA_W isn't usable. In C, it looks like this:</div>
<div><br>
</div>
<div>typedef struct _SP_DEVICE_INTERFACE_DETAIL_DATA_W {<br>
DWORD cbSize;<br>
WCHAR DevicePath[ANYSIZE_ARRAY];<br>
} SP_DEVICE_INTERFACE_DETAIL_DATA_W, *PSP_DEVICE_INTERFACE_DETAIL_DATA_W;<br>
</div>
<div><br>
</div>
<div>It's basically a variable length struct. ANYSIZE_ARRAY is defined as 1. But you are supposed to allocate additional memory for the DevicePath. I guess this is old style trickery that cannot be solved with an automated tool.</div>
<div><br>
</div>
<div>Minor annoyances are:</div>
<div><br>
</div>
<div>- jextract on Windows is a batch file that never returns. So it's not possible to call jextract multiple times for a single batch file.</div>
<div>- It would be nicer if structs used the nice typedef name instead of the ugly struct name, e.g. SP_DEVICE_INTERFACE_DATA_W instead of _SP_DEVICE_INTERFACE_DATA_W (note the leading underscore).</div>
<div><br>
</div>
<div>Overall: success on Windows.</div>
<div><br>
</div>
<div>Regards</div>
<div>Manuel</div>
</div>
<br>
<div class="x_gmail_quote">
<div dir="ltr" class="x_gmail_attr">On Tue, Aug 23, 2022 at 5:48 AM Sundararajan Athijegannathan <<a href="mailto:sundararajan.athijegannathan@oracle.com">sundararajan.athijegannathan@oracle.com</a>> wrote:<br>
</div>
<blockquote class="x_gmail_quote" style="margin:0px 0px 0px 0.8ex; border-left-width:1px; border-left-style:solid; border-left-color:rgb(204,204,204); padding-left:1ex">
<div class="x_gmail-msg-9093422919805539973">
<div dir="ltr">
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
Thanks for your experiments and comments. I'll go over and file bug(s) as needed.</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<br>
</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
-Sundar</div>
<div id="x_gmail-m_-9093422919805539973appendonsend"></div>
<hr style="display:inline-block; width:98%">
<div id="x_gmail-m_-9093422919805539973divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> jextract-dev <<a href="mailto:jextract-dev-retn@openjdk.org" target="_blank">jextract-dev-retn@openjdk.org</a>>
on behalf of Manuel Bleichenbacher <<a href="mailto:manuel.bleichenbacher@gmail.com" target="_blank">manuel.bleichenbacher@gmail.com</a>><br>
<b>Sent:</b> 23 August 2022 02:24<br>
<b>To:</b> <a href="mailto:jextract-dev@openjdk.org" target="_blank">jextract-dev@openjdk.org</a> <<a href="mailto:jextract-dev@openjdk.org" target="_blank">jextract-dev@openjdk.org</a>><br>
<b>Subject:</b> jextract for operating system API</font>
<div> </div>
</div>
<div>
<div dir="ltr">Hi everybody
<div><br>
</div>
<div>As promised, I've compiled my findings when using jextract for the Java Does USB project, which uses the foreign function & memory API to communicate with USB devices on Windows, macOS and Linux. After initial difficulties with jextract, I've written all
the layouts, method and variable handles manually. But now I've given jextract another try. The commands I've used can be found in in the "jextract" branch of the project at <a href="https://github.com/manuelbl/JavaDoesUSB/tree/jextract/java-does-usb/jextract" target="_blank">https://github.com/manuelbl/JavaDoesUSB/tree/jextract/java-does-usb/jextract</a></div>
<div><br>
</div>
<div>Please note that I think that automatically generating code for some of the old Windows and POSIX APIs is almost impossible. My use of jextract (for OS APIs) is probably far from the main use with third-party libraries. And I might also have made mistakes,
or there might be a simple solution to my issues. See my conclusions below for areas where I think jextract has still potential.</div>
<div><br>
</div>
<div><br>
</div>
<div>Linux:</div>
<div><br>
</div>
<div>Overall, I was able to generate most of what I needed with jextract. The issues were:</div>
<div><br>
</div>
<div>- Generating code for libsystemd (sd-device.h) failed with "unknown type name 'intmax_t'". I think this should be defined by inttypes.h, which is included. My guess is that clang headers and Linux headers are mixed up. </div>
<div>- When generating code for usbdevice_fs.h, it didn't generate the constants for USBDEVFS_CLAIMINTERFACE and similar ones. The reason might be that the defines look like functions even though they evaluate to a constant value.</div>
<div><br>
</div>
<div><br>
</div>
<div>macOS:</div>
<div><br>
</div>
<div>Major parts of macOS are provided in the form of frameworks and they are treated in a special way, both when it comes to the header files and dynamic libraries. As an example, my library uses several functions from the CoreFoundation framework. In C/CC++,
you can simply include them like so:<br>
<br>
#include <CoreFoundation/CoreFoundation.h><br>
<br>
That's surprising as the file actually resides in /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/CoreFoundation.framework/Versions/A/Headers/CoreFoundation.h.<br>
<br>
Note that it is in a directory called "Headers" and not in "CoreFoundation" as the include statement suggests. The relative path "CoreFoundation/CoreFoundation.h" does not exist at all.<br>
<br>
This wouldn't be a big problem if this was just the entry point. But this pattern is used recursively. CoreFoundation.h includes about 30 other header files like this, all with a relative path that does not exist.<br>
<br>
Xcode magically resolves this. But jextract seems to be missing this magic. So it cannot be used for any macOS frameworks. In other words, it cannot be for the major part of the macOS APIs. My library uses a single non-framework functions. So using jextract
for macOS is pointless without resolving this issue.<br>
<br>
</div>
<div><br>
</div>
<div>Windows:</div>
<div><br>
</div>
<div>On Windows I spent the most time -- with no success at all. I only partially understand the problems. Here is what I've encountered:</div>
<div><br>
</div>
<div>The first simple goal was to have code for CloseHandle() generated. I tried it three different ways:</div>
<div>
<ul>
<li>Generating code for handleapi.h generated 1000 classes. Code for CloseHandle() was generated in 2 classes, but none of them was publicly available.</li><li>Generating code for handleapi.h restricted to the function CloseHandle() generated a small number of class with a public static method for CloseHandle(). However, at run-time the method produces the error "java.lang.UnsatisfiedLinkError: unresolved symbol:
CloseHandle"</li><li>Generating code for windows.h restricted to CloseHandle() also resulted in the UnsatisfiedLinkError.</li></ul>
<div>I then tried to generate code for Winusb.h. Unfortunately, this header file is not independent. It expects that you have already processed other header files before it. So it fails with "error: unknown type name 'LARGE_INTEGER'". This behavior with be
reproduced in Visual Studio.</div>
</div>
<div><br>
</div>
<div>Next up was Cfgmgr32.h. It also doesn't seem to be independent and fails with "error: unknown type name 'ULONG'". Setupapi.h and Usbioctl.h behave similarly.</div>
<div><br>
</div>
<div>Windows was the only system where I had problems with preprocessor macros. The macro _M_AMD64=100 is certainly needed. That got me further than without it. And I've defined two Unicode macros, copied from the Visual Studio project. But the macros might
still be the source of some problems.</div>
<div><br>
</div>
<div><br>
</div>
<div><br>
</div>
<div>Conclusion:</div>
<div><br>
</div>
<div>At the moment, jextract doesn't help much for accessing OS APIs.</div>
<div><br>
</div>
<div>On Linux, the "unknown type name 'intmax_t'" is worth investigating. It could be helpful for many APIs.</div>
<div><br>
</div>
<div>On macOS, it's all about the frameworks and the magic behind resolving the include path. If it can be made to work, it hopefully opens up the world of framework (plus some challenges that are still hidden).</div>
<div><br>
</div>
<div>On Windows, more investigation is needed. Work on the required macros is needed, as well as more experiments with header files just built for code generation (to get beyond the problem of header files that are not independent).</div>
<div><br>
</div>
<div><br>
</div>
<div>Regards</div>
<div>Manuel</div>
<div> </div>
</div>
</div>
</div>
</div>
</blockquote>
</div>
</div>
</body>
</html>