<!DOCTYPE html><html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
  </head>
  <body>
    <p>Hi Jonathan,<br>
      it would be relatively easy to fix the first two. Harder to fix
      the latter, given jextract uses a canned set of imports for all
      files it generates.</p>
    <p>I'm happy to help if you want to contribute a PR. The classes
      generating the output are called XYZBuilder. E.g. structs are
      generated by StructBuilder class, so it should be easy to find
      what you are looking for.</p>
    <p>Cheers<br>
      Maurizio<br>
    </p>
    <div class="moz-cite-prefix">On 15/05/2024 14:13, Jonathan Rosenne
      wrote:<br>
    </div>
    <blockquote type="cite" cite="mid:DB3PR10MB6786E82CE4FF7985E4D2AE2984EC2@DB3PR10MB6786.EURPRD10.PROD.OUTLOOK.COM">
      
      <meta name="Generator" content="Microsoft Word 15 (filtered medium)">
      <style>@font-face
        {font-family:"Cambria Math";
        panose-1:2 4 5 3 5 4 6 3 2 4;}@font-face
        {font-family:Calibri;
        panose-1:2 15 5 2 2 2 4 3 2 4;}p.MsoNormal, li.MsoNormal, div.MsoNormal
        {margin:0in;
        text-align:right;
        direction:rtl;
        unicode-bidi:embed;
        font-size:11.0pt;
        font-family:"Calibri",sans-serif;
        mso-ligatures:standardcontextual;}p.MsoListParagraph, li.MsoListParagraph, div.MsoListParagraph
        {mso-style-priority:34;
        margin-top:0in;
        margin-right:.5in;
        margin-bottom:0in;
        margin-left:0in;
        text-align:right;
        direction:rtl;
        unicode-bidi:embed;
        font-size:11.0pt;
        font-family:"Calibri",sans-serif;
        mso-ligatures:standardcontextual;}span.EmailStyle17
        {mso-style-type:personal-compose;
        font-family:"Arial",sans-serif;
        color:#1F497D;
        font-weight:normal;
        font-style:normal;
        text-decoration:none none;}.MsoChpDefault
        {mso-style-type:export-only;}.MsoPapDefault
        {mso-style-type:export-only;
        text-align:right;
        direction:rtl;
        unicode-bidi:embed;}div.WordSection1
        {page:WordSection1;}ol
        {margin-bottom:0in;}ul
        {margin-bottom:0in;}</style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
      <div class="WordSection1">
        <p class="MsoNormal" style="text-align:left;direction:ltr;unicode-bidi:embed"><span style="font-size:14.0pt;font-family:"Arial",sans-serif;color:#1F497D">Intellij
            IDEA reports several warnings with the code generated by
            jextract. How difficult would it be to improve it? Of course
            I could let IDEA fix these warnings but I am not sure this
            is a good idea.<o:p></o:p></span></p>
        <p class="MsoNormal" style="text-align:left;direction:ltr;unicode-bidi:embed"><span style="font-size:14.0pt;font-family:"Arial",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
        <p class="MsoNormal" style="text-align:left;direction:ltr;unicode-bidi:embed"><span style="font-size:14.0pt;font-family:"Arial",sans-serif;color:#1F497D">The
            most common ones in my case are:<o:p></o:p></span></p>
        <p class="MsoNormal" style="text-align:left;direction:ltr;unicode-bidi:embed"><span style="font-size:14.0pt;font-family:"Arial",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
        <ol style="margin-top:0in" type="1" start="1">
          <li class="MsoListParagraph" style="color:#1F497D;margin-right:0in;text-align:left;mso-list:l0 level1 lfo1;direction:ltr;unicode-bidi:embed">
            <span style="font-size:14.0pt;font-family:"Arial",sans-serif">The
              final is superfluous:<o:p></o:p></span></li>
        </ol>
        <p class="MsoNormal" style="margin-left:.25in;text-align:left;direction:ltr;unicode-bidi:embed">
          <span style="font-size:14.0pt;font-family:"Arial",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
        <p class="MsoNormal" style="text-align:left;direction:ltr;unicode-bidi:embed"><span style="font-size:14.0pt;font-family:"Arial",sans-serif;color:#1F497D">   /**<span dir="RTL" lang="HE"><o:p></o:p></span></span></p>
        <p class="MsoNormal" style="text-align:left;direction:ltr;unicode-bidi:embed"><span dir="LTR"></span><span dir="LTR"></span><span style="font-size:14.0pt;font-family:"Arial",sans-serif;color:#1F497D"><span dir="LTR"></span><span dir="LTR"></span>     * The layout
            of this struct<o:p></o:p></span></p>
        <p class="MsoNormal" style="text-align:left;direction:ltr;unicode-bidi:embed"><span style="font-size:14.0pt;font-family:"Arial",sans-serif;color:#1F497D">    
            */<span dir="RTL" lang="HE"><o:p></o:p></span></span></p>
        <p class="MsoNormal" style="text-align:left;direction:ltr;unicode-bidi:embed"><span dir="LTR"></span><span dir="LTR"></span><span style="font-size:14.0pt;font-family:"Arial",sans-serif;color:#1F497D"><span dir="LTR"></span><span dir="LTR"></span>    public static
            final GroupLayout layout() {<o:p></o:p></span></p>
        <p class="MsoNormal" style="text-align:left;direction:ltr;unicode-bidi:embed"><span style="font-size:14.0pt;font-family:"Arial",sans-serif;color:#1F497D">       
            return $LAYOUT;<o:p></o:p></span></p>
        <p class="MsoNormal" style="text-align:left;direction:ltr;unicode-bidi:embed"><span style="font-size:14.0pt;font-family:"Arial",sans-serif;color:#1F497D">   
            }<o:p></o:p></span></p>
        <p class="MsoNormal" style="text-align:left;direction:ltr;unicode-bidi:embed"><span style="font-size:14.0pt;font-family:"Arial",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
        <ol style="margin-top:0in" type="1" start="2">
          <li class="MsoListParagraph" style="color:#1F497D;margin-right:0in;text-align:left;mso-list:l0 level1 lfo1;direction:ltr;unicode-bidi:embed">
            <span style="font-size:14.0pt;font-family:"Arial",sans-serif">Field
              may be final<o:p></o:p></span></li>
        </ol>
        <p class="MsoNormal" style="text-align:left;direction:ltr;unicode-bidi:embed"><span style="font-size:14.0pt;font-family:"Arial",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
        <p class="MsoNormal" style="text-align:left;direction:ltr;unicode-bidi:embed"><span style="font-size:14.0pt;font-family:"Arial",sans-serif;color:#1F497D">    
            private static long[] iv$DIMS = { 8 };
            <o:p></o:p></span></p>
        <p class="MsoNormal" style="text-align:left;direction:ltr;unicode-bidi:embed"><span style="font-size:14.0pt;font-family:"Arial",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
        <ol style="margin-top:0in" type="1" start="3">
          <li class="MsoListParagraph" style="color:#1F497D;margin-right:0in;text-align:left;mso-list:l0 level1 lfo1;direction:ltr;unicode-bidi:embed">
            <span style="font-size:14.0pt;font-family:"Arial",sans-serif">Many
              classes have unused imports<o:p></o:p></span></li>
        </ol>
        <p class="MsoNormal" style="text-align:left;direction:ltr;unicode-bidi:embed"><span style="font-size:14.0pt;font-family:"Arial",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
        <p class="MsoNormal" dir="RTL"><span dir="LTR" style="font-size:14.0pt;font-family:"Arial",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
        <p class="MsoNormal" style="text-align:left;direction:ltr;unicode-bidi:embed"><span style="font-size:14.0pt;font-family:"Arial",sans-serif;color:#1F497D;mso-ligatures:none">Best
            Regards,<o:p></o:p></span></p>
        <p class="MsoNormal" style="text-align:left;direction:ltr;unicode-bidi:embed"><span style="font-size:14.0pt;font-family:"Arial",sans-serif;color:#1F497D;mso-ligatures:none"><o:p> </o:p></span></p>
        <p class="MsoNormal" style="text-align:left;direction:ltr;unicode-bidi:embed"><span style="font-size:14.0pt;font-family:"Arial",sans-serif;color:#1F497D;mso-ligatures:none">Jonathan
            Rosenne</span><span style="font-size:14.0pt;color:#1F497D;mso-ligatures:none"><o:p></o:p></span></p>
        <p class="MsoNormal" dir="RTL"><span dir="LTR"><o:p> </o:p></span></p>
      </div>
    </blockquote>
  </body>
</html>