Jigsaw forest now includes JDK 7 M5

Jonathan Gibbons Jonathan.Gibbons at Sun.COM
Thu Nov 12 06:49:01 PST 2009


Andrew John Hughes wrote:
> 2009/11/12 Jonathan Gibbons <Jonathan.Gibbons at sun.com>:
>   
>> Andrew John Hughes wrote:
>>
>> 2009/11/11 Mark Reinhold <mr at sun.com>:
>>
>>
>> If perchance you want to do a boot-cycle build, be sure to apply the
>> attached patch to the jaxws repo first.
>>
>> - Mark
>>
>> --
>>
>> diff --git a/build.properties b/build.properties
>> --- a/build.properties
>> +++ b/build.properties
>> @@ -34,6 +34,9 @@
>>  # one of the standard user build.properties files (see build.xml)
>>  javac.jar=${bootstrap.dir}/lib/javac.jar
>>
>> +# jaxws needs tools.jar too, for the old com.sun.mirror (APT) API
>> +tools.jar=${java.home}/../lib/tools.jar
>> +
>>  # options for the <javac> tasks used to compile the tools
>>  javac.source = 7
>>  javac.target = 7
>> diff --git a/build.xml b/build.xml
>> --- a/build.xml
>> +++ b/build.xml
>> @@ -108,6 +108,8 @@
>>            depends="init, -init-src-dirs, -build-prep">
>>         <javac fork="true"
>>              destdir="${build.classes.dir}"
>> +             includeAntRuntime="false"
>> +             classpath="${build.classes.dir}:${tools.jar}"
>>              memoryInitialSize="${javac.memoryInitialSize}"
>>              memoryMaximumSize="${javac.memoryMaximumSize}"
>>              source="${javac.source}"
>>
>>
>>
>> Wouldn't using ${output.dir}/../langtools/build/classes be better?
>> The above assumes the bootstrap JDK has non-standard (com.sun)
>> classes.
>>
>>
>> I think Kelly is putting a slightly different variant of the patch into TL.
>> That funky path you suggest is definitely not better, since it assumes far
>> too much about the structure within ${output.dir}.
>>
>> -- Jon
>>
>>
>>
>>     
>
> Is there a better way of locating where the langtools build dropped
> its classes?  I think relying on the bootstrap JDK having some
> Sun-specific classes is even worse.  The better long-term solution
> would be to just use the standardised annotation API in jaxws.
>   
In the short term, the correct way to achieve the effect you are 
suggesting is to have the control build pass the location of the 
langtools classes into the jaxws build using ALT_LANGTOOLS_DIST. In the 
long term, apt (and the apt classes involved here) are EOL and will not 
be in JDK 8[1].

-- Jon

[1] I believe Joe already has a terminal cued up with a robotic trigger 
cued  up push the delete key  to delete the apt sources as soon as the 
jdk8 workspaces are opened. :-)



More information about the jigsaw-dev mailing list