modules.{dot,summary} anomalies

Mandy Chung Mandy.Chung at Sun.COM
Fri Nov 13 11:53:20 PST 2009


Alan,

The duplicated dependencies happened only for the fine-grained modules 
that are the top-level module.  Clearing the dependents before fixing up 
the dependencies for all groups fixed the problem.

Mandy

Alan Bateman wrote:
> Mandy,
>
> I notice duplicate dependencies printing to modules.summary and 
> modules.dot when grouping modules. It looks like printModulesSummary 
> and printModulesDot need to first aggregate the dependencies by group 
> (with hard dependency having priority over optional and dynamic 
> dependencies).  Do you have time to fix this or do you want me to fix it?
>
> In passing it also looks like Module.Dependency has issues in that 
> it's hashCode/equals/compareTo don't look right. An easy solution 
> would be to make it immutable and to fix up the issues in the places 
> that use this class. What do you think?
>
> -Alan.




More information about the jigsaw-dev mailing list