ClassAnalyzer -depconfig option

Alan Bateman Alan.Bateman at Sun.COM
Wed Oct 7 07:00:28 PDT 2009


Mandy Chung wrote:
> Alan,
>
> I modify the dependencies output to indicate if a class is marked as 
> an optional dependency.
>
> Webrev at:
>   http://cr.openjdk.java.net/~mchung/jigsaw/tools/webrev.01/
>
> make/config/jdk7.depconfig is the current list of dependencies that 
> are from Class.forName or service provider.  You can add additional 
> dependencies to this list.  You can also specify optional 
> dependencies.  For example, you can add
>
> @Optional java.io.File -> java.nio.file.Path
>
> It specifies that java.nio.file.Path referenced from java.io.File is 
> an optional dependency.
>
> Can you review this change?
>
I just skimmed over it (haven't had time to do a detailed review) and it 
seems reasonable so I'd suggest pushing it. One small comment is that 
"(optional)" might be confusing in the dependencies file because module 
name is also in enclosed by parentheses. One nit is that Reference can 
implement Comparable<Reference>. One suggestion is that you indicate the 
optional dependence in modules.summary and modules.dot too (assuming 
it's not too costly to compute).

-Alan.









More information about the jigsaw-dev mailing list