Use jdk-module-image as boot jdk (modules build + SKIP_BOOT_CYCLE=false)

[Mandy Chung]

On 04/01/10 10:09, Kelly O'Hair wrote:
> 
> On Mar 31, 2010, at 4:15 PM, Mandy Chung wrote:

[...]

>> 4. 
>> http://cr.openjdk.java.net/~mchung/jigsaw/bootdir-modules-image/hotspot/
>>
>>   - The makefile checks if the tools.jar exists for building SA.  In the modular
>>     world, it no longer has the tools.jar.
>>
> 
> In both:
> 
> http://cr.openjdk.java.net/~mchung/jigsaw/bootdir-modules-image/hotspot/src/os/linux/vm/os_linux.cpp.sdiff.html 
> 
> http://cr.openjdk.java.net/~mchung/jigsaw/bootdir-modules-image/hotspot/src/os/solaris/vm/os_solaris.cpp.sdiff.html 
> 
> 
> I'm concerned that the 'buf' character array might overflow.
> Just asking, I didn;t have the time to walk through all of this.

I could clean up to use snprintf.  There are several other places in the 
VM that should handle buffer overflow.

>> An open issue:  the jaxp and jaxws build may download the source bundles.
>> With using jdk-module-image as the boot jdk, jaxp and jaxws build will
>> set ANT_JAVA_HOME to the jdk-module-image that will fail the download
>> as security/crypto support in the modules image is an open issue.
>>
>> Caused by: java.lang.SecurityException: Can not initialize 
>> cryptographic mechanism^M
>>       at javax.crypto.JceSecurity.<clinit>(JceSecurity.java:86)^M
>>
>> I'd like to push this set of changes in jigsaw although there is the jaxp and jaxws
>> bundle download issue.  As long as there is a local downloaded copy of the
>> jaxp/jaxws bundle, it will build fine.
> 
> Inside SWAN, it should find the jaxp/jaxws bundles in 
> /java/devtools/share/jdk7-drops,
> and with JPRT, I think it should find these copies from my 
> /java/devtools copy at
> /opt/jprt/slashjava/devtools/share/jdk7-drops

I ran into this issue when I built on my windows box that didn't set up 
to find these bundles.

> How these source drop bundles are found is a continued issue for me, and  when it
> goes wrong, like Rama found out recently, and the ant script trys to download from
> some foreign http: download site, the ant scripts seem to seize up on  the JPRT clients
> and all hell breaks loose. :^(    Just a warning, but your builds should 
> be ok.

Yes, my jprt job completed successfully.  BTW, I believe that this is 
not a new issue just for modules build.  When we build the legacy image 
with SKIP_BOOT_CYCLE=false from an openjdk repo, it should run into some 
download issue since the cacerts in the openjdk build is empty.

Thanks for the review.
Mandy