changes to org.openjdk.jigsaw.Library

[Jonathan Gibbons]

Mark Reinhold wrote:
>> Date: Mon, 26 Apr 2010 18:17:14 +0100
>> From: jonathan.gibbons at oracle.com
>>     
>
>   
>> Are there notes anywhere on the changes to org.openjdk.jigsaw.Library ?
>>     
>
> Nope.
>
>   
>> There used to be a method called listClasses; that no longer seems to exist,
>> and the replacement seems to be listLocalClasses. However, this method seems to
>> have different semantics -- it returns null, where the old method did not, and
>> some of the javac regression tests are now having trouble locating java.lang,
>> so it would seem the behavior is different as well.
>>     
>
> Yes, the behavior is different: listLocalClasses doesn't look for the
> requested module in any parent libraries, which is probably why you can't
> find java.lang.
>
> I removed the listClasses method while cleaning up the parent-delegation
> logic in changeset 9172f93a9b1d.  Sorry about that -- I wasn't aware you
> were using it, and based upon our past discussions about javac internals
> I assumed that you wouldn't need it.
>
> It's easy enough to add back in -- shall I do that?
>
> - Mark
>   
javac needs some form of list mechanism to be able to determine the 
contents of a package (e.g. import on demand).  I've converted to using 
listLocalClasses, and that fixed one of my two test failures.   I'm 
still investigating the other failure.  Let me find the root cause there 
before asking you to restore listClasses.

-- Jon