Review for the jigsaw module build change

Mark Reinhold mr at sun.com
Tue Feb 2 13:14:46 PST 2010


> Date: Mon, 01 Feb 2010 11:50:49 -0800
> From: mandy.chung at sun.com

> Webrev at:
>   http://cr.openjdk.java.net/~mchung/6921879/webrev.00/
> 
> ...
> 
> o jprt modules build successfully on all platforms

Woo hoo!

>  I fixed a couple issues in the hotspot/make/solaris/makefiles/mapfile-vers
>  jdk/make/java/java/mapfile-vers, and org/openjdk/jigsaw/BootLoader.c.

Thanks.

> ...
> 
> I'd like to push this change to the jigsaw repo tomorrow.
> 
> Alan, do you have cycle to take a look at this webrev?
> 
> There are more to do as listed in make/common/Modules.gmk but
> I think it's good to push this change out so that all of us can
> play with the modular jdk.

Agreed.  I've read most of your webrev and it looks good to me.
Please push your changes once Alan has reviewed them.

Thanks!

- Mark



More information about the jigsaw-dev mailing list