ModuleFileFormat.java patches

Mandy Chung Mandy.Chung at Sun.COM
Thu Feb 25 17:34:39 PST 2010


Mark Reinhold wrote:
> Attached below is the patch I've been using on top of the initial
> ModuleFileFormat patch you sent me a few weeks ago.  Now that your
> initial commit is done, could you please look at integrating these
> changes, adapting them as needed to the latest version?
>
> Summary:
>
>   - Split readModule() into readStart(), which just returns the
>     module-info bytes, and readRest(), which reads the rest of the
>     stream and writes content into files
>
>   - Added a close() method
>
>   - Changed the shape of the output tree so that it matches what
>     SimpleLibrary expects:
>
>         $DST/info             // module-info.class
>             /classes/...
>             /resources/...
>             /lib/...          // Native libraries
>             /bin/...          // Native commands
>             /etc/...          // Configuration files
>
>   
When jmod installs a module with native libraries and other
non-java files, where will those files be installed?  Will
they be installed in the module library exactly in the above
layout?

I'm thinking about installing a jdk module (e.g. sun.management).
Classes and resources are installed in the system module 
library at jre/lib/modules/sun.management/7-ea/

Would lib, bib, etc other directories be installed under 
the same parent as classes & resources (i.e. the module content
directory)?  Or instead there is a way to specify the root
to install the non-java files?  I'm worrying about the RPATH
and native libraries search path.

For jdk modules, "lib" directory may contain files other than
the native libraries.  For example, sun.management has
libmanagement.so as well as other property files under lib.
Just want to mention it and I guess the above is just an 
example and doesn't mean to restrict it to contain 
native libraries only.

Mandy





More information about the jigsaw-dev mailing list