ModuleFileFormat.java patches

[Dalibor Topic]

Mark Reinhold wrote:
> Attached below is the patch I've been using on top of the initial
> ModuleFileFormat patch you sent me a few weeks ago.  Now that your
> initial commit is done, could you please look at integrating these
> changes, adapting them as needed to the latest version?

Done. Thanks for the patches & fixes!

>   - Changed the shape of the output tree so that it matches what
>     SimpleLibrary expects:
> 
>         $DST/info             // module-info.class
>             /classes/...
>             /resources/...
>             /lib/...          // Native libraries
>             /bin/...          // Native commands
>             /etc/...          // Configuration files

I added a static method to map SectionTypes to subdir names, so that I
can use it from test code. Would it make more sense to add a
getLibraryDir method to the corresponding enums?

> Another issue I noticed in your initial patch, but didn't fix, is the
> byte-by-byte copyStream method.  That's practically guaranteed to be a
> performance problem down the road.  It should really use an 8KB buffer.

Yeah, fixed in the initial commit.

cheers,
dalibor topic
-- 
*******************************************************************
Dalibor Topic 			Tel: (+49 40) 23 646 738
Java F/OSS Ambassador 		AIM: robiladonaim
Sun Microsystems GmbH 		Mobile: (+49 177) 2664 192
Nagelsweg 55 			http://openjdk.java.net
D-20097 Hamburg 		mailto:Dalibor.Topic at sun.com
Sitz der Gesellschaft: Sonnenallee 1, D-85551 Kirchheim-Heimstetten
Amtsgericht München: HRB 161028
Geschäftsführer: Thomas Schröder, Wolfgang Engels
Vorsitzender des Aufsichtsrates: Martin Häring