MODULE variable in makefiles limits module-definition refactoring
Mark Reinhold
mr at sun.com
Tue Jan 12 13:35:37 PST 2010
> Date: Tue, 12 Jan 2010 13:05:31 -0800
> From: mandy.chung at sun.com
> It's currently done that way if I understand correctly what you are suggesting.
> The member list for all modules is generated at
> build/linux-i586/tmp/modules/modules.list (one output file for all module
> groups instead of one group).
>
> I added several lowest-level modules such as awt, java2d, etc that are grouped
> under the client module specified in the modules.config so that we can
> experiment with the modules.group without requiring modification to the
> makefiles.
>
> The non-class contents are copied from <outputdir>/tmp/modules in its low-level
> module during the normal build process (i.e. all target). The modularize
> target merges the low-level modules into the corresponding grouped modules in
> the <outputdir>/modules directory.
>
> Does that match what you're suggesting?
Yes, exactly -- my mistake for not reading the makefiles more carefully.
It'd be good to have some explanatory text at the top of modules/Makefile
to explain that the value of the MODULE variable in another makefile
might or might not be the name of the module into which that makefile's
results are copied.
Thanks,
- Mark
More information about the jigsaw-dev
mailing list