Code Review Request: running signed modules with SecurityManager

Rémi Forax forax at univ-mlv.fr
Tue Jun 1 07:00:52 PDT 2010


Le 01/06/2010 15:50, Sean Mullan a écrit :
> I posted a new webrev addressing the comments I have received so far:
>
> http://cr.openjdk.java.net/~mullan/jigsaw/webrevs/SecurityManager2/webrev.01/ 
>
>
> If there are no further comments, I plan to putback later today.
>
> Thanks,
> Sean
>
> Sean Mullan wrote:
>> Please review the webrev below which contains code changes that add 
>> support for running signed modules with a SecurityManager.
>>
>> http://cr.openjdk.java.net/~mullan/jigsaw/webrevs/SecurityManager2/webrev.00/ 
>>
>>
>> Thanks,
>> Sean
>

Some minor nits with the way exception are created:

SimpleLibrary.java:

   throw new InternalError(cnfe.getMessage());

   should be

   throw (InternalError)new InternalError(cnfe.getMessage()).initCause(cnfe


Packager.java:
   - A constructor that takes a String and a cause was added to 
IOException in 1.6.

otherwise I'm okay.

Rémi




More information about the jigsaw-dev mailing list