Review request: rebranding jigsaw sources

Mandy Chung mandy.chung at oracle.com
Thu Jun 3 10:54:29 PDT 2010


On 06/03/10 03:57, Alan Bateman wrote:
> Mandy Chung wrote:
>> Alan, Jon,
>>
>> Can you review the rebranding change of the jdk and langtools jigsaw 
>> source?
>>
>> Webrev at:
>>   http://cr.openjdk.java.net/~mchung/jigsaw/rebrand/jdk
>>   http://cr.openjdk.java.net/~mchung/jigsaw/rebrand/langtools
>>
>> Thanks
>> Mandy
> I scanned the patch file and it looks fine. The only thing I notice is 
> that there are a couple of files 
> (src/share/classes/java/lang/ModuleClassLoader.java and 
> ModuleInfoRead.java for example) that have modifications in 2010 but 
> have 2009 rather than a range in the header.

I believe Kelly's rebranding script doesn't modify the year in the 
copyright.  It's pure a rebranding change.   If we modify a file in 2010 
but without updating the copyright header, the year would be 2009 
instead of a range.

The RE used to run a script to scan the source trees and updates the 
copyright year if a file has any modification.   Kelly is planning to 
update that script that should take care of these files. 

Mandy



More information about the jigsaw-dev mailing list