VM fix for booting from a module
Mandy Chung
Mandy.Chung at Sun.COM
Mon Mar 1 22:08:55 PST 2010
Mark Reinhold wrote:
>> Webrev at:
>> http://cr.openjdk.java.net/~mchung/jigsaw/hotspot-boot-fix/
>>
>> Apparently, the memory problem caused by (1) only showed up in few linux-i586
>> machines but not all. Surprisingly, it didn't show up on solaris i586,
>> windows, and linux-amd64 (at least on the machines I ran the tests).
>>
>> Can you review it?
>>
>
> The fix for (1) is obviously correct.
>
> The fix for (2) looks good, except you should use strncpy instead of
> strcpy so as to avoid buffer overflows.
>
Will fix that.
Thanks.
Mandy
More information about the jigsaw-dev
mailing list