VM fix for booting from a module

[Karen Kinnear]

Thanks Mandy. Looks good

thanks,
Karen

On Mar 2, 2010, at 5:17 PM, Mandy Chung wrote:

> Thanks.  I clean up the fix for #2 to use memcpy and check for the  
> length before copy.
>    http://cr.openjdk.java.net/~mchung/jigsaw/hotspot-boot-fix.1/
>
> Mandy
>
> On 03/02/10 05:50, Karen Kinnear wrote:
>> Mandy,
>> Looks good. Good catch on #1 - I'm so glad you figured it out.
>> thanks,
>> KAren
>> p.s. sorry I didn't see your earlier email on this topic - I seem  
>> to be missing emails far too frequently recently
>> On Mar 1, 2010, at 10:13 PM, Mandy Chung wrote:
>>> Karen, Mark,
>>>
>>> I found two issues with the VM change for booting from a module.
>>> 1. sun.java.launcher.module.boot property added to the system  
>>> property list but the memory is already freed.
>>> 2. resource path for the boot module in the bootclasspath was  
>>> incorrect
>>>
>>> Webrev at:
>>> http://cr.openjdk.java.net/~mchung/jigsaw/hotspot-boot-fix/
>>>
>>> Apparently, the memory problem caused by (1) only showed up in few  
>>> linux-i586 machines but not all.  Surprisingly, it didn't show up  
>>> on solaris i586, windows, and linux-amd64 (at least on the  
>>> machines I ran the tests).
>>>
>>> Can you review it?
>>>
>>> Thanks
>>> Mandy