Add modules target in the forest's topdir Makefile

Kelly O'Hair Kelly.Ohair at Sun.COM
Fri Mar 5 11:46:38 PST 2010


I'm not sure you need the
   ifdef HAVE_JPRT_SAVE_MODULES

I suspect you can just use ifdef BUILD_MODULES, assuming if
modules were built, you would always want them bundled up and
returned back, but it's up to you.

Otherwise, looks fine.

-kto

On 3/5/10 10:15 AM, Mandy Chung wrote:
> Kelly,
>
> I'm adding a "modules" target in the topdir's Makefile that will pass
> the modules target to the jdk build. This provides a convenience way to
> build the jdk module images. In addition, the jprt build will archive
> the jdk-module-image and use it for testing.
>
> Can you please review this change?
> http://cr.openjdk.java.net/~mchung/jigsaw/modules-target/
>
> Thanks
> Mandy



More information about the jigsaw-dev mailing list