Review request for the fix to generate jmod files for jdk modules
Dalibor Topic
Dalibor.Topic at Sun.COM
Fri Mar 5 14:40:19 PST 2010
Mandy Chung wrote:
> Hi Dalibor,
>
> Can you review the change to generate jmod files for
> jdk modules?
Looks fine to me, thanks Mandy!
> I temporarily disable ensureShortNativePath check in
> ModuleFileFormat.java until we make the jdk changes
> to conform the module file format spec (i.e. the path
> names of native-code files must not include more than
> one element and no execute permission set).
OK.
> In addition, I clean up Modules.gmk as there is no reason
> to have the jre subdirectory in the jdk-module-image
> and jdk-base-image. They should be the same as jre-base-image with a
> set of jdk modules installed.
Sounds good, too.
cheers,
dalibor topic
--
*******************************************************************
Dalibor Topic Tel: (+49 40) 23 646 738
Java F/OSS Ambassador AIM: robiladonaim
Sun Microsystems GmbH Mobile: (+49 177) 2664 192
Nagelsweg 55 http://openjdk.java.net
D-20097 Hamburg mailto:Dalibor.Topic at sun.com
Sitz der Gesellschaft: Sonnenallee 1, D-85551 Kirchheim-Heimstetten
Amtsgericht München: HRB 161028
Geschäftsführer: Thomas Schröder, Wolfgang Engels
Vorsitzender des Aufsichtsrates: Martin Häring
More information about the jigsaw-dev
mailing list