jmod problem

[Mandy Chung]

On 03/12/10 08:40, Mark Reinhold wrote:
>> Date: Thu, 11 Mar 2010 19:27:54 -0800
>> From: jonathan.gibbons at sun.com
> 
>> Mandy Chung wrote:
>>> I leave the legacy jdk image as it is today and didn't create a system module
>>> library.  If it's for jtreg tests, you can do jmod create -N -L
>>> /tmp/xxx.
>>>
>>> jdk-module-image is the modular jdk that has the system module library
>>> created.
>> I guess I would suggest that either jmod should not be included in the legacy
>> image, or it should have a more friendly error if there is no system module
>> image available.  There should also be a way for code to query the system to
>> determine if this is a legacy image or a module image, so that tests (for
>> example) can adapt their behavior accordingly.
> 
> Are you trying to run tests using $OUTPUTDIR/bin/java, i.e., the
> development build, rather than one of the $OUTPUTDIR/*-image images?
> 
> Prior to Mandy's most recent changes the development build included the
> lib/modules directory, with all modules pre-installed, and that's the
> default parent library, so $OUTPUTDIR/bin/jmod just worked.  This is
> valuable for development, so I think we should reinstate it.

The reason why I changed it not to preinstall the jdk modules in $OUTPUTDIR
is to fix the images build issue as all $OUTPUTDIR/lib/* are copied 
j2{re,sdk}-image.
Instead the modules are preinstalled in $OUTPUTDIR/tmp/jigsaw-lib/modules
to catch if any module resolution issue.

I somehow neglected our use of $OUTPUTDIR for modules testing/development
but thought that jdk-module-image is adequent for our development purpose.

I will reinstate the preinstallation of jdk modules in $OUTPUTDIR.

Mandy

> The "legacy" j2{re,sdk} images will ultimately be replaced by module
> images.  We could omit the Jigsaw tools from those images for now if
> that makes life simpler.
> - Mark