Detect if bootclasspath/classpath is set in module mode

[Mandy Chung]

On 03/16/10 14:18, Karen Kinnear wrote:
> Mandy,
> 
> Thanks for doing this so quickly.
> 
> The code all looks good.
> So I see you checking for -cp and -classpath on the command line.
> I was under the impression you could also set CLASSPATH in your
> environment. Do we ignore that - that works fine for me I just wanted
> to know if that was intentional.

The check is in java.c line 306-311.  I forgot to mention it in the email.

Alan suggests to rename the is_modular_mode function name in hotspot:
> Looks okay to me. A minor comment is that "is_modules_mode" might be a bit better than "is_modular_mode". 

Do you have any opinion?  I'm thinking is_module_mode (singular) might 
be better.

Mandy

> thanks,
> Karen
> 
> Mandy Chung wrote:
>> Karen, Alan,
>>
>> We don't support bootclasspath and classpath  in module mode.  I added 
>> the check in hotspot and java launcher.  Can you review this simple fix?
>>
>> Webrev at:
>>   http://cr.openjdk.java.net/~mchung/jigsaw/modular-mode-checks/
>>
>> Thanks
>> Mandy
>