Whole file hash in module header

Dalibor Topic Dalibor.Topic at Sun.COM
Fri Mar 19 09:53:31 PDT 2010


Dalibor Topic wrote:
> Sean Mullan wrote:
>> Hi Dalibor,
>>
>> I took a quick scan of the Writer code and it looks like the whole
>> file hash
>> doesn't cover the module file header itself, which I think it should.
>> Is my
>> assumption correct? Is that a known problem?
> 
> Correct - it covers everything after the header, and follows what every
> section hash does (only hash the payload, don't hash the metadata).
> 
> Upon a second reading of the spec, I think you're right, though. So I'll
> update the code to hash the ModuleFileHeader metadata without the final
> byte array.

Fixed with changeset

http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/99ad5eff6fb1

cheers,
dalibor topic
-- 
*******************************************************************
Dalibor Topic 			Tel: (+49 40) 23 646 738
Java F/OSS Ambassador 		AIM: robiladonaim
Sun Microsystems GmbH 		Mobile: (+49 177) 2664 192
Nagelsweg 55 			http://openjdk.java.net
D-20097 Hamburg 		mailto:Dalibor.Topic at sun.com
Sitz der Gesellschaft: Sonnenallee 1, D-85551 Kirchheim-Heimstetten
Amtsgericht München: HRB 161028
Geschäftsführer: Thomas Schröder, Wolfgang Engels
Vorsitzender des Aufsichtsrates: Martin Häring



More information about the jigsaw-dev mailing list