hg: jigsaw/jigsaw/jdk: 2 new changesets

Mandy Chung mandy.chung at oracle.com
Tue May 4 15:52:25 PDT 2010


Hi Dalibor,

The JpkgArgsTest.java test fails with my jigsaw build.  Should jpkg 
check if it's a valid directory before writing the module file?

Mandy

Test: NPE if file argument does not exist:
Test: NPE if file argument is not a directory:
Test: NPE if file argument does not exist:  --config
Test: NPE if file argument is not a directory:  --config
java.lang.Exception
        at JpkgArgsTest.testIfFileArgIsNotADirectory(JpkgArgsTest.java:114)
        at JpkgArgsTest.test(JpkgArgsTest.java:135)
        at JpkgArgsTest.run(JpkgArgsTest.java:47)
        at JpkgArgsTest.main(JpkgArgsTest.java:42)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
        at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:613)
        at 
com.sun.javatest.regtest.MainWrapper$MainThread.run(MainWrapper.java:94)
        at java.lang.Thread.run(Thread.java:717)
Caused by: java.lang.NullPointerException
        at java.util.Arrays$ArrayList.<init>(Arrays.java:2835)
        at java.util.Arrays.asList(Arrays.java:2821)
        at 
org.openjdk.jigsaw.ModuleFileFormat$Writer.writeFile(ModuleFileFormat.java:224)
        at 
org.openjdk.jigsaw.ModuleFileFormat$Writer.writeSection(ModuleFileFormat.java:179)
        at 
org.openjdk.jigsaw.ModuleFileFormat$Writer.writeModule(ModuleFileFormat.java:128)
        at org.openjdk.jigsaw.cli.Packager$Jmod.go(Packager.java:172)
        at org.openjdk.jigsaw.cli.Packager$Jmod.go(Packager.java:147)
        at org.openjdk.jigsaw.cli.Command.run(Command.java:97)
        at org.openjdk.jigsaw.cli.Packager.exec(Packager.java:835)
        at org.openjdk.jigsaw.cli.Packager.run(Packager.java:628)
        at JpkgArgsTest.compress(JpkgArgsTest.java:190)
        at JpkgArgsTest.testIfFileArgIsNotADirectory(JpkgArgsTest.java:109)
        ... 9 more
java.lang.Exception: 1/4 tests failed
        at JpkgArgsTest.run(JpkgArgsTest.java:57)
        at JpkgArgsTest.main(JpkgArgsTest.java:42)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
        at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:613)
        at 
com.sun.javatest.regtest.MainWrapper$MainThread.run(MainWrapper.java:94)
        at java.lang.Thread.run(Thread.java:717)

JavaTest Message: Test threw exception: java.lang.Exception: 1/4 tests 
failed
JavaTest Message: shutting down test


dalibor.topic at sun.com wrote:
> Changeset: 71cd6d39fd42
> Author:    robilad
> Date:      2010-05-04 18:59 +0200
> URL:       http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/71cd6d39fd42
>
> Check if argument is a directory before use
>
> ! src/share/classes/org/openjdk/jigsaw/cli/Packager.java
> ! test/org/openjdk/jigsaw/cli/JpkgArgsTest.java
>
> Changeset: 06ff25743b7a
> Author:    robilad
> Date:      2010-05-04 19:00 +0200
> URL:       http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/06ff25743b7a
>
> Automated merge with http://hg.openjdk.java.net/jigsaw/jigsaw/jdk
>
>
>   




More information about the jigsaw-dev mailing list