Review request: Install module content into zip files

Dalibor Topic Dalibor.Topic at Sun.COM
Fri May 21 11:34:11 PDT 2010


mark.reinhold at oracle.com wrote:
> The previous version of this method included the assert but also some
> later logic to handle the case of type == MODULE_INFO.  While refactoring
> I removed that later logic and also the assert.  I'll restore the assert.

thanks! and thanks for the refactorings.
 
> Feel free to revise/enhance Files.java as needed.

thanks, will do, and post for review once your patch goes in.

cheers,
dalibor topic
-- 
*******************************************************************
Dalibor Topic                   Tel: (+49 40) 23 646 738
Java F/OSS Ambassador           AIM: robiladonaim
Sun Microsystems GmbH           Mobile: (+49 177) 2664 192
Nagelsweg 55                    http://openjdk.java.net
D-20097 Hamburg                 mailto:Dalibor.Topic at sun.com
Sitz der Gesellschaft: Sonnenallee 1, D-85551 Kirchheim-Heimstetten
Amtsgericht München: HRB 161028
Geschäftsführer: Jürgen Kunz





More information about the jigsaw-dev mailing list