Review of platform modules & class analyzer change

Alan Bateman Alan.Bateman at oracle.com
Mon May 24 08:57:07 PDT 2010


Mandy Chung wrote:
> Webrev at:
>   http://cr.openjdk.java.net/~mchung/jigsaw/platform-modules
>
> Summary of Changes:
> 1. All module names are qualified names with "jdk.*" or "sun.*"
>   prefix.
> 2. Class analyzer to generate requires optional in module-info.java
> 3. Take make/docs/NON_CORE_PKGS.gmk to prepare for the analysis
>   of public non-platform supported APIs.
> 4. Fix Resolver to link with optional modules if exist
> 5. Move make/modules/tools to make/tools/classanlyzer so it will
>   be built once.
>
> Thanks
> Mandy
I went through the module changes and the make files changes and they 
look okay to me. I've scanned the updates to the class analyzer tool but 
I haven't done a detailed review. Will do, if you need a detailed review 
before you push this.

-Alan.



More information about the jigsaw-dev mailing list