Please review fix to StackOverflowError in jigsaw tracing
Mandy Chung
mandy.chung at oracle.com
Mon May 24 09:17:53 PDT 2010
On 05/24/10 05:55, Alan Bateman wrote:
> Mandy Chung wrote:
>> :
>> Thanks for the comment. I revise the fix:
>> http://cr.openjdk.java.net/~mchung/6951456/webrev.01/
> This looks better. A couple of comments:
>
> Is "inited" used now? It doesn't appear to be and so can be removed.
I removed it.
>
> Cache.print does more than the method name suggests. Maybe Cache.drain
> or printAndClear?
>
Renamed it to Cache.printAndClear.
> Otherwise I think it's okay.
>
Thanks for the review.
Mandy
More information about the jigsaw-dev
mailing list