Code Review Request: running signed modules with SecurityManager

[Rémi Forax]

Le 27/05/2010 00:02, Sean Mullan a écrit :
> Please review the webrev below which contains code changes that add 
> support for running signed modules with a SecurityManager.
>
> http://cr.openjdk.java.net/~mullan/jigsaw/webrevs/SecurityManager2/webrev.00/ 
>
>
> Thanks,
> Sean

In Loader.java, you should declare the two maps and the sets final.

In SimpleLibrary.readLocalCodeSigners,
if the file is removed between f.exists() and
new FileInputstream, instead of returning null, you throw an IOException,
furthermore, reading the doc of Library.readLocalCodeSigners,
it's far from than than you can returns an array of signers with one element
which is null.
I would prefer to directly get null in that cases or a better documentation.

In Packager, outptuFile.delete() can returns false.


A more general question but perhaps for Mark or Alan,
why jigsaw codebase use java.io.file and not java.nio.file ?

Rémi