Code Review Request: running signed modules with SecurityManager

[Mandy Chung]

On 05/26/10 15:02, Sean Mullan wrote:

> Please review the webrev below which contains code changes that add support for 
> running signed modules with a SecurityManager.
>   
> http://cr.openjdk.java.net/~mullan/jigsaw/webrevs/SecurityManager2/webrev.00/
>   
>   
Some minor comments:

ModuleClassLoader.java
  Should the defineModule method take a CodeSource parameter?

Library.java:
   line 355: I wonder if the returned type should prefer Set<CodeSigner>
   to an array while the existing methods such as JarEntry.getCodeSigners
   return CodeSigner[]?

Loader.java:
   line 196:  Are we going to create a CodeSource object with a non-null
   URL some time?

SimpleLibrary.java
  line 540: When CNFE is thrown, I think AssertionError or InternalError
  is more appropriate.

Packager.java
  line 237, 242 - you can use Files.delete(() that will throw IOException 
  if it fails to delete the file.

Mandy