Review request on the optional modules support

Mandy Chung mandy.chung at oracle.com
Thu Aug 4 16:33:34 PDT 2011


  On 08/04/11 13:18, Jesse Glick wrote:
>> A new @RequireOptionalModule annotation is defined to indicate that 
>> the annotated type
>
> "Annotated element" I guess (includes methods); Javadoc needs to be 
> edited.
>

Fixed.

>> http://openjdk.java.net/projects/jigsaw/doc/topics/optional.html
>
> Open question #1 - does it not suffice that @ROM is @Documented? 

I think @Document + @throws ModuleNotPresentException will suffice.
@ROM implies "@throws ModuleNotPresentException" and it's a good
practice to specify @throws in the javadoc.   I don't see a need to add
a new javadoc tag.  I included the question there to see if anyone thinks
differently.

Mandy



More information about the jigsaw-dev mailing list