ClassAnalyzer patch

Alan Bateman Alan.Bateman at oracle.com
Thu Aug 11 06:40:13 PDT 2011


Mandy Chung wrote:
> Alan,
>
> I have updated the class analyzer to use the modules from the jigsaw 
> module library for generating its module-info.java.  Below is one 
> example of module-info.java ClassAnalyzer output for SwingSet3 demo 
> and jdesktop libraries [1].
>
> module swingset3 @ 1.0 {
>     requires jdesktop.animation @ 1.0;
>     requires jdesktop.appframework @ 1.0;
>     requires jdesktop.swingx @ 1.0;
>     requires jdk.base @ 7-ea;
>     requires jdk.desktop @ 7-ea;
>     requires jdk.logging @ 7-ea;
>     class com.sun.swingset3.SwingSet3;
> }
>
>
> Webrev at:
>    
> http://cr.openjdk.java.net/~mchung/jigsaw/webrevs/classanalyzer-update-full/ 
>
>
> I also added make/tools/classanalyer/classanalyzer.html to include 
> some information about this tool.
>
> The above webrev includes the class analyzer change I included in [2] 
> so that it can be pushed separately.  The delta from [2] might be 
> useful if you have already reviewed the previous version:
>    
> http://cr.openjdk.java.net/~mchung/jigsaw/webrevs/classanalyzer-update.00/ 
>
I skimmed through the changes in the delta webrev and it all seems 
reasonable and straight-forward (I didn't to review every line, which I 
think it okay at this point).

Just on the full webrev, I see updates to the module config. One odd one 
is that zipfs shouldn't be in net-ext as it's a file system provider 
rather than anything network related. Otherwise looks fine to me.

-Alan.





More information about the jigsaw-dev mailing list